[PATCH] D83544: [DebugInfo] Support for DW_AT_associated and DW_AT_allocated.

Alok Kumar Sharma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 09:45:15 PDT 2020


alok marked 2 inline comments as done.
alok added a comment.

In D83544#2151182 <https://reviews.llvm.org/D83544#2151182>, @aprantl wrote:

> Mechanically, this looks great! it would be good to add a little more context to the LangRef documentation (see my inline comment).


Thanks a lot for your comments. Your comments will be incorporated in next version of patch



================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-allocatedExp.ll:6
+; CHECK-LABEL:  DW_TAG_array_type
+; CHECK:        DW_AT_allocated (DW_OP_push_object_address, DW_OP_deref)
+; CHECK:       DW_TAG_subrange_type
----------------
aprantl wrote:
> add `CHECK-NOT: DW_TAG` in between to ensure we're still in the same TAG
Thanks for your comment. This will be incorporated in next version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83544/new/

https://reviews.llvm.org/D83544





More information about the llvm-commits mailing list