[PATCH] D81166: [Matrix] Add matrix_nuw/matrix_nsw operand bundles for matrix.multiply.

Wed Jul 15 09:41:52 PDT 2020

fhahn planned changes to this revision.
fhahn added a comment.

In D81166#2134596 <https://reviews.llvm.org/D81166#2134596>, @reames wrote:

> (drive by comments only, please don't block on me)

Thanks, that's very much appreciated!

> Reading over this, I find myself wondering if this is actually matrix specific.  Would it make sense to have a means to declare the operations in an reduce.add are nsw/nuw?

Not really, it would could be used by other intrinsics as well. I'll try to generalize it.

> As a semantic clarification, does the nsw/nuw markers on the matrix make any assumptions about order of operations?

I don't think the order of operations should matter, because the order we sum the results of the multiplications should not impact whether we overflow or not I think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81166/new/

https://reviews.llvm.org/D81166