[PATCH] D83252: [XCOFF] Enable symbol alias for AIX

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1841
+          "alias without a base object is not yet supported on AIX");
+    GOAliasMap[Base].push_back(&Alias);
+  }
----------------
if Base ->isDeclarationForLinker() is true. it should not have a alias, do we need to add assert here ?


================
Comment at: llvm/test/CodeGen/PowerPC/aix-alias.ll:24
+ at bar_p = protected alias i32, i32* @bar
+ at fun_ptr = global i32()* @bar_f, align 4
+
----------------
Xiangling_L wrote:
> You can simplify the testcase by removing `align 4` all over the test.
in the doc .https://llvm.org/docs/LangRef.html#aliases .  The linkage must be one of private, internal, linkonce, weak, linkonce_odr, weak_odr, external.

Do you want to test the linkonce, weak_odr,and external by the way?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83252/new/

https://reviews.llvm.org/D83252