[PATCH] D83187: [LoopUnroll] Update branch weight for remainder loop

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 08:53:25 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp:808
+  if (remainderLoop && !UnrollRemainder) {
+    uint64_t TrueWeight, FalseWeight;
+    if (LatchBR->extractProfMetadata(TrueWeight, FalseWeight)) {
----------------
It is better to fold this part into the update method too with one additional parameter for unroll factor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83187/new/

https://reviews.llvm.org/D83187





More information about the llvm-commits mailing list