[PATCH] D83329: [PGO][PGSO] Add profile guided size optimization to loop vectorization legality.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

yamauchi marked an inline comment as done.
yamauchi added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:418
+  bool OptForSize = F->hasOptSize() ||
+                    llvm::shouldOptimizeForSize(TheLoop->getHeader(), PSI, BFI,
+                                                PGSOQueryType::IRPass);
----------------
davidxl wrote:
> should the check of F->hasOptSize() also folded into llvm::shouldOptimizeForSize()?
That's actually been suggested before and seems to make sense, and is in my todo list for a while. But it'd be a different patch because it'd be an API change and apply to many sites that have been instrumented with llvm::shouldOptimizeForSize() so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83329/new/

https://reviews.llvm.org/D83329