[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Digger via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:882
+
+XCOFFTracebackTable::XCOFFTracebackTable(const uint8_t *Ptr, uint64_t Size,
+                                         Error &Err)
----------------
jasonliu wrote:
> We passed in a pointer and a size to this constructor function and create function, so caller knows how big the traceback table is. 
> I think in general we need to have a way to tell caller some of the content is not parsed when that happens. 
> i.e. everything in the traceback looks good, but it has some extra bytes in the end we do not recognized. 
> So that caller maybe able to just dump the raw bytes out if they want, and print out a general message saying:" Some of the traceback table content is not recognized and here are the raw bytes."
I added a data member "TBTSize" to store the valid traceback table size and API for it.
When the caller want  to print out the table content is not recognized , it can not the api the get the valid size.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:922
+
+  // TODO: Need to parse vector Info and extension table if there is.
+}
----------------
jasonliu wrote:
> I'm Okay with these TODOs if we are actually going to provide a patch for it right after we land this patch.
yes, we will have a patch for vector info and long table after the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585