[llvm] 9ea0d8c - [LoopRotate] Remove unnecessary verifyMemorySSA calls.

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 03:52:51 PDT 2020


Author: Florian Hahn
Date: 2020-07-15T11:49:24+01:00
New Revision: 9ea0d8c38fc58ecec2e2f62f3b65e99fcbc2ec4c

URL: https://github.com/llvm/llvm-project/commit/9ea0d8c38fc58ecec2e2f62f3b65e99fcbc2ec4c
DIFF: https://github.com/llvm/llvm-project/commit/9ea0d8c38fc58ecec2e2f62f3b65e99fcbc2ec4c.diff

LOG: [LoopRotate] Remove unnecessary verifyMemorySSA calls.

The actual rotation happens in processLoop, so the second removed
call to verifyMemorySSA was unnecessary.

In fact, processLoop/rotateLoop already verify MemorySSA before
and after transforming each loop. Hence, both calls can be removed.

Pointed out by @lebedev.ri post-commit D51718.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/LoopRotationUtils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp b/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
index 8804bba975b6..da1c09e6ebca 100644
--- a/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
@@ -740,12 +740,7 @@ bool llvm::LoopRotation(Loop *L, LoopInfo *LI, const TargetTransformInfo *TTI,
                         const SimplifyQuery &SQ, bool RotationOnly = true,
                         unsigned Threshold = unsigned(-1),
                         bool IsUtilMode = true) {
-  if (MSSAU && VerifyMemorySSA)
-    MSSAU->getMemorySSA()->verifyMemorySSA();
   LoopRotate LR(Threshold, LI, TTI, AC, DT, SE, MSSAU, SQ, RotationOnly,
                 IsUtilMode);
-  if (MSSAU && VerifyMemorySSA)
-    MSSAU->getMemorySSA()->verifyMemorySSA();
-
   return LR.processLoop(L);
 }


        


More information about the llvm-commits mailing list