[PATCH] D83772: [Windows] Fix limit on command line size

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added a comment.

Thank you for your detailed feedback!

> Round down to 32,000 to leave us wiggle room.

As there is no requirement to use response files as rarely as possible, the choice of the limit is an implementation detail. Having some wiggle room is a good idea in this case.

> Have flattenWindowsCommandLine return a wstring rather than a string. This will reduce the chance of the proxy string we measure differing from the actual command string we're issuing, and it's already a Windows-specific function.

Agree, this is more robust solution.

> Add a short command to the test for commandLineFitsWithinSystemLimits.

Now the patch is more than a change of a constant, so a test is necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83772/new/

https://reviews.llvm.org/D83772