[PATCH] D79219: [CMake] Simplify CMake handling for zlib

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 02:28:36 PDT 2020


labath added a comment.

I wouldn't mind separate (internal) cache variable, though I am somewhat surprised by this problem. A (non-cache) variable set in one of the parent scopes should still take precedence over a cache variable with the same name. And since config-ix.cmake is included from the top CMakeLists.txt, the value it defines should be available everywhere. Was this a problem for the regular build, or only for some of the more exotic build setups that don't start with llvm/CMakeLists.txt ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219





More information about the llvm-commits mailing list