[PATCH] D83710: TableGen/GlobalISel: Allow output instructions with multiple defs

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 02:27:42 PDT 2020


foad added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4394-4395
+    if (I > 0) {
+      // Patterns only handle a single result, so results after the first is an
+      // implicitly dead def.
+      const TypeSetByHwMode &ExtTy = Dst->getExtType(I);
----------------
"results after the first is" is bad English. How about "any result after the first is" ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83710/new/

https://reviews.llvm.org/D83710





More information about the llvm-commits mailing list