[PATCH] D83462: [DWARF] Avoid entry_values production for SCE

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 2 inline comments as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:429
   // the debug entry values feature. It can also be enabled explicitly.
-  EmitDebugEntryValues = (Asm->TM.Options.ShouldEmitDebugEntryValues() &&
-                          (tuneForGDB() || tuneForLLDB())) ||
-                         EmitDwarfDebugEntryValues;
+  EmitDebugEntryValues = Asm->TM.Options.ShouldEmitDebugEntryValues();
 
----------------
aprantl wrote:
> Wouldn't we want `(tuneForGDB() || tuneForLLDB())` to override the target default? If someone were to debug with a hypothetical GDB port for SCE targets, for example?
We can still do that by using the `-debug-entry-values` option?


================
Comment at: llvm/test/DebugInfo/MIR/X86/DW_OP_entry_value.mir:18
 
+# SCE-NOT: DW_OP_GNU_entry_value
+
----------------
aprantl wrote:
> Wouldn't you want to check for `DW_OP_{{.*}}entry_value`?
It makes sense, thanks! The default @entry encoding for SCE will be GNU in this case, but it is safe to check both in the case the behavior changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83462/new/

https://reviews.llvm.org/D83462