[PATCH] D83247: [compiler-rt][asan][hwasan] Refactor shadow setup into sanitizer_common (NFCI)

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Looks like FUCHSIA is OK and does not call these stuff



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_common_libcdep.cpp:191
+
+static void UnmapFromTo(uptr from, uptr to) {
+  if (to == from)
----------------
UnmapFromTo and MapDynamicShadow must go into sanitizer_linux_libcdep.cpp as libcdep applies to windows/mac and other


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_win.cpp:356
+  const uptr alignment =
+      Max(granularity << shadow_scale, 1UL << min_shadow_base_alignment);
+  const uptr left_padding = Max(granularity, 1UL << min_shadow_base_alignment);
----------------
Max<uptr> and below, or it does not compile on windows
1UL is 32bit here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83247/new/

https://reviews.llvm.org/D83247