[PATCH] D83845: [LTO/WPD] Remove special type test handling for -flto-visibility-public-std

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson created this revision.
tejohnson added a reviewer: pcc.
Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion.
Herald added a project: clang.

As discussed in follow up comments on D71913 <https://reviews.llvm.org/D71913>, the special case handling
for -flto-visibility-public-std of not inserting type tests is unneeded,
because that is a Windows option, and the Windows linker does not
support the -lto-whole-program-visibility option which would relax the
visibility. By default, the type tests will get public visibility, which
is what we want for the std classes under that option, and it can't be
relaxed. Therefore the handling that was preventing the type tests from
being inserted (to avoid any visibility relaxation) isn't needed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83845

Files:
  clang/lib/CodeGen/CGClass.cpp
  clang/lib/CodeGen/CGVTables.cpp
  clang/lib/CodeGen/CodeGenModule.h
  clang/lib/CodeGen/ItaniumCXXABI.cpp
  clang/test/CodeGenCXX/lto-visibility-inference.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83845.278058.patch
Type: text/x-patch
Size: 5834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200715/00b462f1/attachment.bin>