[PATCH] D83843: [llvm][NFC] Hide the tensorflow dependency from headers.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 19:39:13 PDT 2020


mtrofin created this revision.
mtrofin added reviewers: mehdi_amini, davidxl.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

This change avoids exposing tensorflow types when including TFUtils.h.
They are just an implementation detail, and don't need to be used
directly when implementing an analysis requiring ML model evaluation.

The TFUtils APIs, while generically typed, are still not exposed unless
the tensorflow C library is present, as they currently have no use
otherwise.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83843

Files:
  llvm/include/llvm/Analysis/Utils/TFUtils.h
  llvm/lib/Analysis/InlineSizeEstimatorAnalysis.cpp
  llvm/lib/Analysis/TFUtils.cpp
  llvm/unittests/Analysis/TFUtilsTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83843.278054.patch
Type: text/x-patch
Size: 18812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200715/f86a93bb/attachment.bin>


More information about the llvm-commits mailing list