[PATCH] D83747: [argprom] Assessing impact of magic value MaxElements promoted on compiler performance

Tue Jul 14 18:47:23 PDT 2020

teamiceberg abandoned this revision.
teamiceberg marked 2 inline comments as done.
teamiceberg added a comment.

A new patch will be put in to baseline against the latest LLVM Master Commit (at least at the time of uploading this patch).

================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:98
-cl::opt<unsigned, true> argmax("maxar", cl::Required, cl::desc("Specify number of args to promote"), cl::value_desc("maxargs"), cl::location(llvm::GL_MAXARGS));
->>>>>>> df0f0e791671d16f15d67c1f265b75f5a35a7624

----------------
jdoerfert wrote:
> Can you please update this diff to be against a proper commit of the master branch?
I am putting in a new diff so it can against the very latest master commit. SO I will be abandoning this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83747/new/

https://reviews.llvm.org/D83747