[PATCH] D83725: [llvm-mc] Add --doc-id=<id> to support multiple documents in a file

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 17:33:58 PDT 2020


MaskRay added a comment.

In D83725#2150173 <https://reviews.llvm.org/D83725#2150173>, @probinson wrote:

> Wouldn't using `.ifdef` directives with `--defsym` on the command line work equally well?  At least for .s files run through llvm-mc.
>  There are examples of this in the lit tests already, easy enough to find.


I somehow forgot this. `.ifdef ERR` + `llvm-mc --defsym=ERR=1` seems convenient enough (e.g. D83751 <https://reviews.llvm.org/D83751>) so I am dropping this patch.

Create D83834 <https://reviews.llvm.org/D83834> for the standalone utility 'extract'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83725/new/

https://reviews.llvm.org/D83725





More information about the llvm-commits mailing list