[PATCH] D83807: [flang][openacc] Semantic checks for OpenACC 3.0 clauses validity

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 2 inline comments as done.
clementval added a comment.

Thanks for the review. All comments were addressed. Thanks for the `parser::Unwrap`, didn't know this one.



================
Comment at: flang/lib/Semantics/canonicalize-acc.cpp:41
+private:
+  template <typename T> T *GetConstructIf(parser::ExecutionPartConstruct &x) {
+    if (auto *y{std::get_if<parser::ExecutableConstruct>(&x.u)}) {
----------------
klausler wrote:
> Can be `const`, or (better) `static`, or (best) in parser/tools.h.
Not necessary anymore with `parser::Unwrap`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83807/new/

https://reviews.llvm.org/D83807