[PATCH] D83743: [InlineAdvisor] New inliner advisor to replay inlining from optimization remarks

Tue Jul 14 16:53:34 PDT 2020

mtrofin added a comment.

In D83743#2150725 <https://reviews.llvm.org/D83743#2150725>, @wenlei wrote:

> In D83743#2150703 <https://reviews.llvm.org/D83743#2150703>, @davidxl wrote:
>
> > Can this be extended to the SCC inliner?
>
>
> Yes, we can use it in SCC inliner as well. We just need extra plumbing there. We can do that in a separate change if needed.

I'd be curious what the scenario in the SCC case would be. IIUC, here, the value is that you can replay decisions made with a profile, and use a different profile for everything else in the compiler. Hmm... I suppose maybe a similar scenario could be articulated for the SCC case?

On this - could you please add in the patch description the motivating scenario (helps with understanding) - thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83743/new/

https://reviews.llvm.org/D83743