[PATCH] D83507: [AssumeBundles] Fix Bug in Assume Queries

Tue Jul 14 16:09:08 PDT 2020

Tyker added a comment.

In D83507#2145353 <https://reviews.llvm.org/D83507#2145353>, @lebedev.ri wrote:

> Also, this either needs a rebase, or this isn't against master but the stack doesn't say so.

The patch should apply cleanly now. it was conflicting with an other path that landed.

In D83507#2145318 <https://reviews.llvm.org/D83507#2145318>, @lebedev.ri wrote:

> In D83507#2142683 <https://reviews.llvm.org/D83507#2142683>, @Tyker wrote:
>
> > In D83507#2142627 <https://reviews.llvm.org/D83507#2142627>, @lebedev.ri wrote:
> >
> > > Test?
> >
> >
> > i would also like to add a test for it, but the smallest reproduction example is still very big 30k+ line of IR
> >  and depend on what is present in the AssumptionCache so i could only reproduce it under -O3 run.
> >  it isn't minimized at all but minimizing it in a way that still exibit the bug is quite hard
>
>
> Can you at least post the reproducer+steps as-is?

one way to see the effect of the bug is to try to run ADT unitest compiled with stage1 clang with -O3 -mllvm --enable-knowledge-retention.
this test should have test failures caused by this bug.

one of the files in which a miscompile occurs is /home/tyker/opensource/llvm-project/llvm/unittests/ADT/ImmutableSetTest.cpp
here is the unoptimized IR that triggers the bug.
F12339456: tmp.ll <https://reviews.llvm.org/F12339456>
running: opt -O3 --enable-knowledge-retention tmp.ll

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83507/new/

https://reviews.llvm.org/D83507