[PATCH] D83816: Document the -analyze opt flag in the LLVM testing guide (NFC)

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 15:59:11 PDT 2020


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm with some minor wording nits



================
Comment at: llvm/docs/TestingGuide.rst:50
 and are located in the ``llvm/unittests`` directory.
+In general unit tests are reserved to test targeting the support library and
+generic data structure, we prefer relying on regression tests for testing
----------------
reserved to test -> reserved to tests?


================
Comment at: llvm/docs/TestingGuide.rst:71
+
+Analysis are passes that are inferring properties on some part of the IR and not
+transforming it. They are tested in general using the same infrastructure as the
----------------
grammar nit: "An analysis is a pass that infers..." (or some other way)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83816/new/

https://reviews.llvm.org/D83816





More information about the llvm-commits mailing list