[PATCH] D82344: [NewPM] Make PMs and adaptor passes for PMs unskippable
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 14 15:59:02 PDT 2020
asbirlea added a comment.
I'm inclined to favor having the `isRequired()` method optional with the SFINAE in this patch.
It's up to you two which patch to actually keep, but I'd say update this patch, with renaming to `isRequired()` (and flipping the bool value), adding the default to `true` in `isRequired()` for all adaptors and if, as you mentioned the diff can be simplified, great, but if not, this one makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82344/new/
https://reviews.llvm.org/D82344
More information about the llvm-commits
mailing list