[PATCH] D83592: [Parser] Add comment to skipped regions
Zequan Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 14 15:28:02 PDT 2020
zequanwu added a comment.
In D83592#2151217 <https://reviews.llvm.org/D83592#2151217>, @vsk wrote:
> Could you add an end-to-end llvm-cov test (see e.g. compiler-rt/test/profile/Linux/coverage_ctors.cpp)? Here are some important cases I think we should check:
>
> - `/* comment at the start of a line */ expr;`
> - `expr; /* comment at the end of a line */`
> - `expr; // comment at the end of a line`
> - `// comment spanning entire line`
>
> In all but the last case, llvm-cov should report an execution count for the line. Testing multi-line variations of those cases would also be helpful.
llvm-cov doesn't report the execution count for the first 3 liens... I will try to fix that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83592/new/
https://reviews.llvm.org/D83592
More information about the llvm-commits
mailing list