[PATCH] D83807: [flang][openacc] Semantic checks for OpenACC 3.0 clauses validity

[Tim Keith via Phabricator via llvm-commits]

tskeith added inline comments.


================
Comment at: flang/lib/Semantics/canonicalize-acc.cpp:36
+        }
+      }
+    } // Block list
----------------
You should be able to simplify this by using `parser::Unwrap` here. That is,
`auto *accLoop{parser::Unwrap<parser::OpenACCLoopConstruct>(*it)`


================
Comment at: flang/lib/Semantics/canonicalize-acc.cpp:69
+    if (++nextIt != block.end()) {
+      if (auto *doCons{GetConstructIf<parser::DoConstruct>(*nextIt)}) {
+        if (doCons->GetLoopControl()) {
----------------
Can use `parser::Unwrap` here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83807/new/

https://reviews.llvm.org/D83807