[PATCH] D82975: [DebugInfo] Allow GNU macro extension to be emitted

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 13:25:40 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good (one small nit/change to a comment in the new test case) - thanks!



================
Comment at: llvm/test/DebugInfo/X86/debug-macro-gnu-dwo.ll:1-2
+; It is unclear if the GNU .debug_macro extension is well-specified for split
+; DWARF. For now, verify that a .debug_macinfo.dwo section is emitted when
+; -gdwarf-4 -gsplit-dwarf -fdebug-macro is specified, regardless of the GNU
----------------
`well-specified for split DWARFv4`, specifically, I think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82975/new/

https://reviews.llvm.org/D82975





More information about the llvm-commits mailing list