[PATCH] D83765: [SVE] Add lowering for scalable vector fadd, fdiv, fmul and fsub operations.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

In D83765#2151141 <https://reviews.llvm.org/D83765#2151141>, @efriedma wrote:

> With this patch, we take an unpredicated operation, convert it to a predicated operation, then convert it back to an unpredicated operation?  That seems a little strange at first glance, but I guess it makes the SelectionDAG more uniform.


The "convert it back to an unpredicated operation" part only applies to packed scalable vector types (and even then only fadd, fmul and fsub).  Operations on unpacked scalable and fixed length vector (after a follow on patch) types remain predicated.  I did consider restricting the lowering to only apply in those cases but figured it wasn't worth it since the _PRED patterns need to be written anyway.  The same goes for any post lowering combines that prove valuable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83765/new/

https://reviews.llvm.org/D83765