[PATCH] D83635: [OpenMPOpt][WIP] Merge parallel regions

[Giorgis Georgakoudis via Phabricator via llvm-commits]

ggeorgakoudis marked 4 inline comments as done.
ggeorgakoudis added inline comments.


================
Comment at: llvm/test/Transforms/OpenMP/parallel_region_merging.ll:13
+;    void merge_all() {
+;    #pragma omp parallel
+;        {
----------------
hfinkel wrote:
> Do these need to say 'nowait' in order to actually match the code?
No, the code matches the IR generation ('nowait' is available only for worksharing constructs). The merging transformation emits an explicit barrier in place of the implicit barrier after merging. However, I added a TODO because it could make sense to avoid explicit barrier generation, if the 'nowait' clause is present in an enclosing worksharing construct, and the merged parallel regions are independent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83635/new/

https://reviews.llvm.org/D83635