[PATCH] D83503: [buildbot] Annotated builder tweaks

Tue Jul 14 12:13:16 PDT 2020

tra added a comment.

In D83503#2149127 <https://reviews.llvm.org/D83503#2149127>, @gkistanova wrote:

> Please make sure all the scripts annotated builder could run are in zorg.

I'm a bit confused. If allowing to run external scripts is OK, then such script would not come from the zorg repo by definition. Are you suggesting that we should not allow external scripts and only the ones under `zorg/buildbot/builders/annotated/` should ever be run?

If external scripts are OK, then what's the point keeping them in zorg repo?

I don't mind publishing the scripts. However I am not convinced that zorg is the right place for 
all the things build machines will get to run. It's impossible in practice to put everything under zorg's control because the script 
launched by buildslave may rely on external infrastructure, pre-staged data, networking setup, etc.

That was the idea of this patch -- to introduce a clean cut-off point between the things controlled centrally by zorg repo (let the builder know when to do another build and collect the results) and the things that would be administered locally by buildslave owners (how to actually build/test a given revision).
While many bots are uniform enough to let buildmaster micromanage them, it's not always the case and the separation of responsibilities would be very useful, IMO, at least in some cases where things are a bit more complicated than "cheskout source, run cmake, run ninja".

If you prefer to have not-particularly-reusable build script in the repo as some sort of reference, I'm OK with it, even if I don't see much value there.

Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83503/new/

https://reviews.llvm.org/D83503