[PATCH] D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction.

[James Y Knight via Phabricator via llvm-commits]

jyknight marked an inline comment as done.
jyknight added inline comments.


================
Comment at: llvm/test/CodeGen/X86/callbr-asm-sink.ll:24
+  %2 = getelementptr inbounds %struct1, %struct1* %0, i64 0, i32 1
+  callbr void asm sideeffect "# $0 $1 $2", "*m,X,~{memory},~{dirflag},~{fpsr},~{flags}"(i32* %2, i8* blockaddress(@klist_dec_and_del, %3))
+          to label %6 [label %3]
----------------
nickdesaulniers wrote:
> what is `$2` in this case if there's only 2 parameters explicitly passed into the `asm`? Maybe you can drop that here and in the `CHECK-NEXT` above?
Oops, that was an oversight, I'll fix before pushing. I'm rather surprised this isn't an error -- who knew you could index into the clobber arguments (other than "memory"), in LLVM asm!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83708/new/

https://reviews.llvm.org/D83708