[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: clang/lib/Headers/altivec.h:17153
+/* vs[l | r | raq] */
+static __inline__ vector unsigned __int128 __ATTRS_o_ai
+vec_slq(vector unsigned __int128 __a, vector unsigned __int128 __b) {
----------------
I believe there are supposed to be `signed` and `unsigned` versions of the functions? It looks like you currently have all of them as `unsigned`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83338/new/

https://reviews.llvm.org/D83338