[PATCH] D83743: [InlineAdvisor] New inliner advisor to replay inlining from optimization remarks

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

In D83743#2150725 <https://reviews.llvm.org/D83743#2150725>, @wenlei wrote:

> In D83743#2150703 <https://reviews.llvm.org/D83743#2150703>, @davidxl wrote:
>
> > Can this be extended to the SCC inliner?
>
>
> Yes, we can use it in SCC inliner as well. We just need extra plumbing there. We can do that in a separate change if needed.


Thanks for the work, using inline advisor to replay inline is exactly something we want too.

Currently every inline remark message has only one level: one caller, one callee and one callsite (maybe with multiple levels of inline stack associated with the callsite). One problem I am thinking of is: the inline advisor may only work with top-down inlining. In bottom-up inlining, if we decide to inline a specific callsite, it will actually be inlined at many places after its caller also being inlined into multiple places in the caller's callers. Since SCC inliner uses bottom-up inlining, current format of inline advise may not provide precise enough information to specify an exact location where inlining is expected to happen.

Have you ever considered to use a callpath to specify the inlining location?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83743/new/

https://reviews.llvm.org/D83743