[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`
Jon Chesterfield via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 14 10:13:14 PDT 2020
JonChesterfield added a comment.
Agreed on tests. I like the mechanism - passing a string through to the backend as a way to dispatch between isa properties looks cleanly extensible. We probably do want to emit a warning when the backend claims it doesn't know anything about said string as it'll be prone to typos.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83281/new/
https://reviews.llvm.org/D83281
More information about the llvm-commits
mailing list