[PATCH] D83468: [Debuginfo] Fix for PR46653

[Jaydeep Chauhan via Phabricator via llvm-commits]

Jac1494 marked an inline comment as done.
Jac1494 added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1990
   // (The new location might be an explicit line 0, which we do emit.)
-  if (DL.getLine() == 0 && LastAsmLine == 0)
+  if (DL.getLine() == 0 && LastAsmLine != 0)
     return;
----------------
probinson wrote:
> It looks like this change will suppress emitting an explicit line-0 location.  We definitely want to emit line-0 in many cases, so this patch is going too far.
Can you please provide me testcase where line entry "0" is required..?
I couldn't find the use case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83468/new/

https://reviews.llvm.org/D83468