[PATCH] D83370: [CallGraph] Ignore callback uses

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 09:49:55 PDT 2020


lebedev.ri resigned from this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

I don't actually have any opinion here, i just wanted to get the bots green (:



================
Comment at: llvm/lib/Analysis/CallGraph.cpp:84
+  // it is not a callback, then anything could call it.
+  if (!F->hasLocalLinkage() || F->hasAddressTaken(nullptr, IgnoreCallbackUses))
     ExternalCallingNode->addCalledFunction(nullptr, Node);
----------------
Why not just `/*IgnoreCallbackUses=*/true`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83370/new/

https://reviews.llvm.org/D83370





More information about the llvm-commits mailing list