[PATCH] D83651: [FileCheck] Report captured variables

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 277852.
jdenny added a comment.

Removed an unused parameter from `printVariableDefs`.

Made unit testing of `getStringValue` stricter.

Added unit test for `printVariableDefs`.  This is just a basic API test and doesn't check every aspect, such as sorting.  More thorough testing appears in the FileCheck utility tests.  Should we replicate all that here too?  What's the general rule?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83651/new/

https://reviews.llvm.org/D83651

Files:
  llvm/lib/Support/FileCheck.cpp
  llvm/lib/Support/FileCheckImpl.h
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/verbose.txt
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83651.277852.patch
Type: text/x-patch
Size: 15599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200714/caf25242/attachment.bin>