[PATCH] D83780: MIPS: change FeatureMadd4 to FeatureNoMadd4

YunQiang Su via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 08:25:06 PDT 2020


wzssyqa created this revision.
wzssyqa added a reviewer: atanasyan.
Herald added subscribers: llvm-commits, jrtc27, hiraditya, arichardson, sdardis.
Herald added a project: LLVM.

FeatureMadd4 here is used to disable madd4, and the option is

  (+-)nomadd4

This word is so confused here. 
Changing to FeatureNoMadd4 makes it much more clear.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83780

Files:
  llvm/lib/Target/Mips/Mips.td
  llvm/lib/Target/Mips/MipsInstrInfo.td


Index: llvm/lib/Target/Mips/MipsInstrInfo.td
===================================================================
--- llvm/lib/Target/Mips/MipsInstrInfo.td
+++ llvm/lib/Target/Mips/MipsInstrInfo.td
@@ -242,7 +242,7 @@
 def HasMSA : Predicate<"Subtarget->hasMSA()">,
              AssemblerPredicate<(all_of FeatureMSA)>;
 def HasMadd4 : Predicate<"!Subtarget->disableMadd4()">,
-               AssemblerPredicate<(all_of (not FeatureMadd4))>;
+               AssemblerPredicate<(all_of (not FeatureNoMadd4))>;
 def HasMT  : Predicate<"Subtarget->hasMT()">,
              AssemblerPredicate<(all_of FeatureMT)>;
 def UseIndirectJumpsHazard : Predicate<"Subtarget->useIndirectJumpsHazard()">,
Index: llvm/lib/Target/Mips/Mips.td
===================================================================
--- llvm/lib/Target/Mips/Mips.td
+++ llvm/lib/Target/Mips/Mips.td
@@ -191,7 +191,7 @@
                                "UseTCCInDIV", "false",
                                "Force the assembler to use trapping">;
 
-def FeatureMadd4
+def FeatureNoMadd4
     : SubtargetFeature<"nomadd4", "DisableMadd4", "true",
                        "Disable 4-operand madd.fmt and related instructions">;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83780.277840.patch
Type: text/x-patch
Size: 1189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200714/d06f9caf/attachment.bin>


More information about the llvm-commits mailing list