[PATCH] D83651: [FileCheck] Report captured variables

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D83651#2150335 <https://reviews.llvm.org/D83651#2150335>, @jdenny wrote:

> In D83651#2150334 <https://reviews.llvm.org/D83651#2150334>, @thopre wrote:
>
> > In D83651#2149514 <https://reviews.llvm.org/D83651#2149514>, @thopre wrote:
> >
> > > Could you add an example where getStringValue() returns None?
> >
> >
> > Sorry, I meant in the testcases. Maybe something with @LINE since you mention it.
>
>
> Ah, you mean the unittests, right?  I keep forgetting about those for FileCheck.


Actually no, I was thinking of a case where printVariableDefs is called with a variable with no string value but I can't think of a case where this would happen. Having unittest for printVariableDefs is a good idea though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83651/new/

https://reviews.llvm.org/D83651