[PATCH] D83651: [FileCheck] Report captured variables

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 07:10:50 PDT 2020


jdenny added a comment.

In D83651#2149514 <https://reviews.llvm.org/D83651#2149514>, @thopre wrote:

> Could you add an example where getStringValue() returns None?


It's set to `None` for  `@LINE` and numeric variables defined on the command line.  I've extended the comments to mention these cases.

Both of these cases are tested elsewhere in the test suite.  `getStringValue` is not called for them, so there's nothing new to test, as far as I can tell.

Does that make sense?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83651/new/

https://reviews.llvm.org/D83651





More information about the llvm-commits mailing list