[PATCH] D83032: [utils] New script `check_ninja_deps.py`

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham marked an inline comment as done.
simon_tatham added inline comments.


================
Comment at: llvm/utils/check_ninja_deps.py:178
+            # stale data from targets that existed only in past builds in the
+            # same directory.
+            if (dep in targets and currtarget in deps and
----------------
thakis wrote:
> This also means you have to make sure that latter deps for a file overwrite earlier deps for a file, iirc (the old entry might be stale)
They do, as far as I can tell: if I change the includes in a source file and re-run ninja, then the result of `ninja -t deps` includes a stanza showing the new dependencies for the generated object, and no stanza for the old dependencies.

>From reading the source comments, it looks as if previous versions of the dependencies for a file might sometimes still exist in the `.ninja_deps` log on disk, but they're not printed by the `deps` tool I'm calling here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83032/new/

https://reviews.llvm.org/D83032