[PATCH] D83625: [TSan] Optimize handling of racy address

Joachim Protze via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 06:01:11 PDT 2020


protze.joachim added a comment.

I agree, that the patch changes the transitive suppression of reports. Unfortunately, this would bring back the overhead of reconstructing the remote stack trace.

As a follow-up patch I was thinking about adding a "suppress_equal_location" flag.  
I would only compare the local stack trace with previously reported stack traces in `racy_stacks`.
Initially I was thinking about suppress_equal_pc, but especially for wrapper functions, the top pc is function pointer of the wrapper.

Also, I plan to add a `suppress_max_stack_depth=n` flag. The `HandleRacyStacks` function will only compare the top n frames in this case.
For race in recursive algorithms, this will allow to remove duplicates with different recursion depth. (For OpenMP, this specifically helps for tasking programs)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83625/new/

https://reviews.llvm.org/D83625





More information about the llvm-commits mailing list