[PATCH] D80975: [SCEV][IndVarSimplify] insert point should not be block front if the front instruction is a PHI

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:1443
+  if (!WidePhi)
+    return nullptr;
 
----------------
the expandCodeFor always modifies current function, but returning nullptr is interpreted as « no change ». This makes pass return status invalid (the pass return false while a change actually happened).

This breaks validation http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/9441/, and there wasn't a simple patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80975/new/

https://reviews.llvm.org/D80975