[PATCH] D83391: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager

Tue Jul 14 04:15:14 PDT 2020

djtodoro marked an inline comment as done.
djtodoro added inline comments.

================
Comment at: llvm/include/llvm/IR/LegacyPassManager.h:100
+/// needed.
+class DebugifyCustomPassManager : public legacy::PassManager {
+  DebugifyStatsMap DIStatsMap;
----------------
vsk wrote:
> vsk wrote:
> > The layering for this seems a bit strange, as LegacyPassManager doesn't have much to do with 'debugify'. How does moving the class into Debugify.h, and the class implementation into Debugify.cpp sound? That way, the new-PM version of this can live in the same files.
> To be clear: I'm not asking that you implement a new-PM version of this, it's just some future-proofing.
Nice point, thanks!

I'd rather keep the class def in the Debugify.h in order to avoid linking additional stuff into the `libLLVMTransformUtils` (for example, `isBitcodeWriterPass()` won't be available while linking without CMake changes). WDYT?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83391/new/

https://reviews.llvm.org/D83391