[PATCH] D83654: [PowerPC] Support constrained vector fp/int conversion

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8638
 
   return DAG.getNode(Opc, dl, Op.getValueType(), Extend);
 }
----------------
It would seem that this doesn't create a correct node when called with a STRICT version of Opc -- for one, in this case it will need to handle chains correctly (in and out).

It is strange that this was not detected by any tests -- is the coverage good enough?

The rest of the algorithm seems OK for the strict case, since it only introduces integer operations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83654/new/

https://reviews.llvm.org/D83654