[PATCH] D83636: omp: Make OMP tablegen more like all other tablegens.

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D83636#2147351 <https://reviews.llvm.org/D83636#2147351>, @thakis wrote:

> It puts the C++ code in C++ files :)


The C++ code is currently in a C++ files (`OMP.cpp` that replaces `OMPConstants.cpp`). I don't get this comment.

> I agree there are merits to both approaches, but this is the one used ~everywhere else in LLVM and clang, so if it's a wash it seems good to stay consistent with the rest of the codebase.

MLIR is using similar technics for the dialects code. As I said, I don't have a strong opinion on this but I would like @jdoerfert to have look at this before going forward if you don't mind. It feels just weird to me to re-generate macros to be used to generate code that we can generate directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83636/new/

https://reviews.llvm.org/D83636