[PATCH] D83592: [Parser] Add comment to skipped regions

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Before updating any tests, maybe it's worth doing a quick experiment with comments placed in different contexts, to see whether adding these skipped regions is really sufficient. For example, given:

  1|  for (auto x : collection) {
  2|    // Explain the loop.
  3|  }

The loop region covers lines 1-3. If we skip the comment range on line 2, does an execution count from the loop region still get picked up? I'd expect it to. It's possible that we need more information from the preprocessor about whether the line is fully comment/whitespace-only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592