[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 16:33:09 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/X86/cfi-basic-block-sections-1.ll:49
+
+; There must be 1 CIE and 3 FDEs
+
----------------
MaskRay wrote:
> Comments tend to be full sentences (with period).
> 
> You may consider `;; ` for tests. IIRC update_llc_test_checks.py can sometimes drop comments. We can teach update_llc_test_checks.py to retain comments with `;; `
Typo: You may consider ;;  for **comments** (not RUN or CHECK lines)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978





More information about the llvm-commits mailing list