[PATCH] D83389: [MIR] Speedup parsing (up to 1000x+)

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 16:28:22 PDT 2020


dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRParser/MIParser.cpp:566
   CurrentSource = lexMIToken(
-      CurrentSource.data() + SkipChar, Token,
+      CurrentSource.slice(SkipChar, StringRef::npos), Token,
       [this](StringRef::iterator Loc, const Twine &Msg) { error(Loc, Msg); });
----------------
drop_front(SkipChar) might be simpler/clearer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83389/new/

https://reviews.llvm.org/D83389





More information about the llvm-commits mailing list