[PATCH] D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction.

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 13:53:57 PDT 2020


jyknight added inline comments.


================
Comment at: llvm/test/CodeGen/X86/callbr-asm-sink.ll:8
+
+%struct1 = type { i8*, i8*, i8*, i32 }
+
----------------
nickdesaulniers wrote:
> Looks like we only access the third element of this struct in the GEP, IIUC the GEP correctly?
Yeah. Needs to be a non-zero offset but other than that doesn't matter; I can get rid of the middle elements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83708/new/

https://reviews.llvm.org/D83708





More information about the llvm-commits mailing list