[PATCH] D83708: Remove TwoAddressInstructinoPass::sink3AddrInstruction.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 12:44:14 PDT 2020


nickdesaulniers added a comment.

> I could fix that bug, but, as the removed FIXME noted, attempting to
>  move instructions _before_ converting to 3-addr, so as to avoid
>  needing to make the conversion in the first place is a better
>  idea.

Also, that sentence has more than the legally allowed number of commas. Please consider breaking it up into multiple sentences.  Maybe:

> I could fix that bug but as the removed FIXME noted, attempting to
>  move instructions _before_ converting to 3-addr so as to avoid
>  needing to make the conversion in the first place, is a better
>  idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83708/new/

https://reviews.llvm.org/D83708





More information about the llvm-commits mailing list