[PATCH] D83651: [FileCheck] Report captured variables

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked 3 inline comments as done.
jdenny added inline comments.


================
Comment at: llvm/lib/Support/FileCheckImpl.h:117
   bool Negative;
+  StringRef StrValue;
 
----------------
thopre wrote:
> I think I'd prefer this as a new field in NumericVariable. ExpressionValue is really an abstraction for signed/unsigned variable. It's used for all intermediate result of evaluating the AST of an expression and for all of those the StrValue means nothing and is of no interest. I realize the size penalty is small, it bothers me more on a conceptual level.
> 
> Does that make sense?
That does make sense.  Applied.  Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83651/new/

https://reviews.llvm.org/D83651