[PATCH] D79625: [PowerPC] Extend .reloc directive on PowerPC

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp:118
       { "fixup_ppc_pcrel34",     0,      34,   MCFixupKindInfo::FKF_IsPCRel },
+      { "fixup_ppc_linker_opt",  0,       0,   0 },
       { "fixup_ppc_nofixup",     0,       0,   0 }
----------------
nemanjai wrote:
> This is going to need `MCFixupKindInfo::FKF_IsPCRel` or else it needs to be moved to the non-PC-Rel section of the switch in `getRelocType()`.
I think I'm going to end up moving this to the non PC-Rel section. 


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCELFStreamer.cpp:212
+
+    // If the symbol expression is not a binary expression we can let the base
+    // class handle the issue.
----------------
nemanjai wrote:
> Is this comment actually true? It seems that if the expression is not a binary expression, we assert.
You are right. That comment is out of date. We do assert now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79625/new/

https://reviews.llvm.org/D79625